[go: nahoru, domu]

CloseAll: Refactor for potential performance improvements

This CL adds some quick changes to the toast system implemented in
CloseAll.

First, it has ToastManagerImpl erase the ToastOverlay entry for the root
window when the root window is removed so that we do not have empty
entries for root windows that are no longer in use.

Second, it has MaybeCommitPendingDeskRemoval check if there is a
temporary_removed_desk_ before resetting the temporary_removed_desk_ and
setting in motion the close process for the active toast.

Third, it changes expired_callback_ to a OnceClosure so that the
expired_callback_ is guaranteed to only run once for any one desk
closure. This is important especially with the multi-monitor toasts that
were introduced in Close-All, where each toast would fire the same
RepeatingClosure when they are being destroyed. This also necessitated
moving ownership of the expired_callback to ToastData so that
there is only one owner of the OnceClosure. The destructor for ToastData will then run expired_callback.

Bug: b:258054693, b:258054862, b:258036878
Change-Id: I67bb5eef03eab26e43554f1ecc17a437bf69aa8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4017921
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ben Becker <benbecker@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1071187}
27 files changed
tree: 6b79fc497b8d188fd1ea875f44fda4ca14a9941b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.