commit | e180731ca2c3cce3f329cdadedf8fafaa801337a | [log] [tgz] |
---|---|---|
author | Ben Becker <benbecker@chromium.org> | Mon Nov 14 20:25:08 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Nov 14 20:25:08 2022 |
tree | 6b79fc497b8d188fd1ea875f44fda4ca14a9941b | |
parent | 67cfb0f1623b37a950506282d0b12a7bfc847b36 [diff] |
CloseAll: Refactor for potential performance improvements This CL adds some quick changes to the toast system implemented in CloseAll. First, it has ToastManagerImpl erase the ToastOverlay entry for the root window when the root window is removed so that we do not have empty entries for root windows that are no longer in use. Second, it has MaybeCommitPendingDeskRemoval check if there is a temporary_removed_desk_ before resetting the temporary_removed_desk_ and setting in motion the close process for the active toast. Third, it changes expired_callback_ to a OnceClosure so that the expired_callback_ is guaranteed to only run once for any one desk closure. This is important especially with the multi-monitor toasts that were introduced in Close-All, where each toast would fire the same RepeatingClosure when they are being destroyed. This also necessitated moving ownership of the expired_callback to ToastData so that there is only one owner of the OnceClosure. The destructor for ToastData will then run expired_callback. Bug: b:258054693, b:258054862, b:258036878 Change-Id: I67bb5eef03eab26e43554f1ecc17a437bf69aa8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4017921 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ben Becker <benbecker@chromium.org> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1071187}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.