| commit | e2516381060ed85496aa052416a80e1b175759c2 | [log] [tgz] |
|---|---|---|
| author | Dale Curtis <dalecurtis@chromium.org> | Fri Sep 21 22:13:39 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Sep 21 22:13:39 2018 |
| tree | bfee7580d9941be6c499a1e21e32904d34b5e24e | |
| parent | e33c0c5936848f5f59017e76262fbd7bcaac7609 [diff] |
Remove base::ResetAndReturn usage. Switch to bool callback checks.
base::ResetAndReturn is deprecated and .is_null() syntax is onerous.
Mechanically done via:
git grep --name-only "base::ResetAndReturn(\&" | \
xargs sed -i "s/base::ResetAndReturn(\&/std::move(/g"
git grep --name-only -e "_cb_\.is_null\(\)" *.cc | \
xargs sed -ri "s/!([a-zA-Z0-9_]*)_cb_\.is_null\(\)/\1_cb_/g"
git grep --name-only -e "_cb_\.is_null\(\)" *.cc | \
xargs sed -ri "s/([a-zA-Z0-9_]*)_cb_\.is_null\(\)/\!\1_cb_/g"
git grep --name-only -e "_cb\.is_null\(\)" *.cc | \
xargs sed -ri "s/!([a-zA-Z0-9_]*)_cb\.is_null\(\)/\1_cb/g"
git grep --name-only -e "_cb\.is_null\(\)" *.cc | \
xargs sed -ri "s/([a-zA-Z0-9_]*)_cb\.is_null\(\)/\!\1_cb/g"
Bug: none
Test: compiles, passes cq
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7bb2bd9da08a4749b69bfbc6d3f471a1cfc1d6c0
Reviewed-on: https://chromium-review.googlesource.com/1239200
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593351}Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .