| commit | e33a081250775c99db16a12765ccdc0b5f4834d5 | [log] [tgz] |
|---|---|---|
| author | Stephen McGruer <smcgruer@chromium.org> | Tue Jul 18 15:56:09 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jul 18 15:56:09 2023 |
| tree | cd6280ca02f6d464e13a47b2a4c7a3624e4d7d22 | |
| parent | 3889c7fa3b9c46a602c215ec7b695031f75f90da [diff] |
Revert "Update Slide out behavior for notification popups" This reverts commit 778a81b45cfdd30e37c07b7cc2615882d0d96cda. Reason for revert: Suspect of causing ASAN and MSAN failures, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/52378/overview and https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/37207/overview Original change's description: > Update Slide out behavior for notification popups > > This CL modifies the slide out behavior for notification popups when > a `MessageCenterView` exists. > In this case, the popup is dismissed but the notification will stay > in the MessageCenter until the user explicitly removes it. > > Bug: b:288337446 > Change-Id: Iebf8c751cb1041bb30964dabc1b9b5551269551c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4679290 > Reviewed-by: Andre Le <leandre@chromium.org> > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> > Reviewed-by: Toshiki Kikuchi <toshikikikuchi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1171411} Bug: b:288337446 Change-Id: I6ce92f118e5e80a3e7a4a0592a5893d737a2ee5c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4694896 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Owners-Override: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1171776}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.