commit | e363aecd8d66d9eeb88afd5ea4ab8a74b9bb2c16 | [log] [tgz] |
---|---|---|
author | Manu Cornet <manucornet@chromium.org> | Sun Jan 13 13:07:07 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Sun Jan 13 13:07:07 2019 |
tree | c675c086bd679ea0dd934e8575885456d66650ed | |
parent | bb39def6f7a80e954b6c40cb494cdfacc1c86a8e [diff] |
CrOS shelf: refactor some code between the various shelf button classes Change the hierarchy a bit: ShelfButton / \ / \ ShelfAppButton ShelfControlButton (new class) \ {AppList,Back,Overflow}Button This allows us to gather some logic common to all shelf buttons into the ShelfButton class and avoid a bit of duplication in all subclasses. The ShelfAppButton class is very close to the former ShelfButton class. The new ShelfButton class is a lot shorter. Also remove the ink drop listener constructor argument, since there were no occurrences where that listener was different from the shelf view (so we only need the shelf view as a constructor argument). Yay deletions! Bug: 714781 Change-Id: I5d39e9f58a457513a475c1c499dee60baa8d8b5a Reviewed-on: https://chromium-review.googlesource.com/c/1396319 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#622346}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .