| commit | e371c7066cd13d653880b6dbac5e61feaa28e80f | [log] [tgz] |
|---|---|---|
| author | Toni Barzic <tbarzic@chromium.org> | Wed Jan 10 02:19:45 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 10 02:19:45 2024 |
| tree | 4977c1d002e223dcf9cab3afcee6eb2199514b75 | |
| parent | f071190d1e3fe7d899ce71212de25c8e7a2b4901 [diff] |
Scope SearchResultImageViewDelegate to image list Instead of using a global SearchResultImageViewDelegate instance in SearchResultImageViews, scope the delegate to an SearchResultImageListView, and pass it to SearchResultImageViews in their constructors. Using a global SearchResultImageViewDelegate had an invalid assumption that at most one instance could exist at the time - this did not take into account that both bubble and tablet mode launcher have their own SearchResultImageListView, and thus their own SearchResultImageViewDelegate. Change-Id: I4ed0257262a792679e130ca08d83a903b237b229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5181716 Reviewed-by: Wen-Chien Wang <wcwang@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1245050}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.