[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / e3966b157a2be969a7a7b5eb0063abb89d0579bf
commite3966b157a2be969a7a7b5eb0063abb89d0579bf[log] [tgz]
authorMaksim Moskvitin <mmoskvitin@google.com>Tue Jan 21 13:03:39 2020
committerCommit Bot <commit-bot@chromium.org>Tue Jan 21 13:03:39 2020
tree136edc9139997ef9da3d388b4812ac342b10828b
parent1ba73ef0669f9d52bb222fdde95124452de99a12 [diff]
Fix crash in ProfileSyncService::GetDisableReasons()

PeopleHandler somehow gets destroyed after ProfileSyncService shutdown,
so |auth_manager_| is nullptr during its destruction. This caused the
crash in GetDisableReasons().

Fix is to simply check |auth_manager_| before dereferencing. Avoiding
PSS usages after shutdown would be cleaner fix, but it's not clear why
they happen atm.

Bug: 1043642, 906995
Change-Id: Id6d54a2edee1210a579e36b2b771d360c8c40474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011220
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733582}
2 files changed
tree: 136edc9139997ef9da3d388b4812ac342b10828b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .