[go: nahoru, domu]

M123: Add tests for OOPPD GDI metafile variations

Windows print drivers for which the browser does a PDF conversion to a
form other than regular EMF have been found to cause blank pages when
the out-of-process print drivers feature is enabled.  This is due to
the Print Backend service treating all GDI jobs as one single type of
EMF object, which is problematic since PostScript is handled with a
different EMF playback method at printing time.

Gain coverage for this scenario by extending the browser tests based on
SystemAccessProcessSandboxedServicePrintBrowserTest to include the
Windows printer language type in the test parameterization.

Update the TestPrintingContext logic to support specifying the language
type that the faked printer driver is supposed to expect.  This allows
for adding a check that provided page metafile data matches the
expectation.

To communicate this expected type to the Print Backend service, the
necessary additional mojom MetafileDataType must be included as part of
adding these tests.  To show the current problematic behavior, the
PrintBackendServiceImpl still creates the same EMF metafile object for
this new type.

Together these changes show that the metafile objects created for
PostScript and text-only print drivers are incorrectly handled by the
Print Backend service, so that the playback of such objects will not
provide imaging as desired.

(cherry picked from commit a8bc2d1f87a7b3e5a911923a7233714c084d0caa)

Bug: 41492268
Change-Id: Icca0a89c1a9cde102f4ec04874470536468c5cc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5333336
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1268739}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5361239
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#536}
Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
8 files changed
tree: 81884f431d52168abc128473435efe19485b19bc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.