commit | ecb41b936378223e2544a8e1781f52e2f9d2334d | [log] [tgz] |
---|---|---|
author | Lei Zhang <thestig@chromium.org> | Thu Feb 03 20:48:17 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 03 20:48:17 2022 |
tree | 76e3fe8b8992f4d860f9f893aca59f5490d4e284 | |
parent | 4a18563617d73836fdb905279b5f3e9a5afbb1fa [diff] |
Align base::win::GenericScopedHandle APIs with base::ScopedGeneric's. base::ScopedPlatformFile is implemented with base::win::GenericScopedHandle and base::ScopedGeneric, on Windows and POSIX, respectively. When a cross-platform caller gets back a base::ScopedPlatformFile, the caller cannot easily use the base::ScopedPlatformFile in some cases because the APIs for the platform-specific implementions are named differently. Improve this situation with the following renames to line up the APIs: IsValid() -> is_valid() Get() -> get() Take() -> release() Keep methods with the old names as wrappers around the actual implementation, to avoid breaking the build. They will be removed separately. Bug: 1291793 Change-Id: I9b41edc9007a126a315ff657578f26f3875bce5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3426390 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#966896}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.