| commit | ecf738d661b3e8633c438c7cb865d6f2b7a1d2a8 | [log] [tgz] |
|---|---|---|
| author | Garrett Beaty <gbeaty@chromium.org> | Tue Dec 01 18:37:53 2020 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 01 18:37:53 2020 |
| tree | 5c818b4171e1b6945600e1a797dc808f1072002b | |
| parent | a425f98e0f104146b81485ff4dde36cadad1cfa0 [diff] |
Encapsulate the xcode handling within the base builder function. Currently, the xcode_cache enum contains declarations only for the xcode cache itself and builders must specify the matching xcode_build_version property. Additionally, the handling of inserting the cache and setting the property needs to be performed in any wrapper function that wants to set the xcode to a specific value. This change puts the handling in the lowest level and groups all of the xcode details into a single struct so that builders and wrapper functions can just specify the xcode value. Change-Id: Ia90829bb9124f93d4dcc48c67321289288a4c06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566616 Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#832433}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.