[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / ee8a5d646573cfdcae3c95c5543209d17affd47c
commitee8a5d646573cfdcae3c95c5543209d17affd47c[log] [tgz]
authorMing-Ying Chung <mych@chromium.org>Fri Nov 10 09:01:57 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 10 09:01:57 2023
tree56f42deadeb6a11a10ac17c06ec1601ebbb6ff02
parent0a91c9026b5268939b2f3e229a526b879bd35040 [diff]
Update fetch keepalive WPT helper

1. Updated `assertStashedTokenAsync()` as pointed out in [1] that it
   may not properly wait until token is fetched. Also added more error
   msg. This leads to issues fixed by (4) below.
2. Renamed `disallowOrigin` to `disallowCrossOrigin` to make it clear.
3. In keepalive-related tests, renamed the arg `shouldPass`:
   - for `assertStashedTokenAsync()`: `expectTokenExist`
   - for other references in tests: `expectFetchSucceed`
4. Fixed `stash-put.py` which didn't handle `cors` / `no-cors`
   requests properly. Previously:
   - for `cors` request without `disallow_cross_origin`, it
     still stores the token; however it should not.
   - for `no-cors` request, there was no special treatment; after this
     CL, it should always store the token no matter
     `disallow_cross_origin` is provided or not.
5. Extended `keepaliveRedirectTest()` to support the case without
   unloading its iframe.


[1]: https://crrev.com/c/4988570/11/third_party/blink/web_tests/external/wpt/fetch/api/redirect/redirect-keepalive.https.any.js#20

Bug: 1356128
Change-Id: I72926789ac3af7ee7d04dc95128f2685d7d21df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5014033
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1222812}
5 files changed
tree: 56f42deadeb6a11a10ac17c06ec1601ebbb6ff02
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.