[go: nahoru, domu]

Reland "Move colorspace handling from xformcanvas to surface"

This reverts commit 1d9a01590325372eb4bdd906f17230f599ffe870.

Reason for revert: updated new test baseline

Original change's description:
> Revert "Move colorspace handling from xformcanvas to surface"
> 
> This reverts commit 63d1658ac9a9568fbed928855d042ea0ca63b923.
> 
> Reason for revert: Newly added test is failing on WebKit Win https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/47246
> 
> Original change's description:
> > Move colorspace handling from xformcanvas to surface
> > 
> > Now that skia can perform all colorspace transformations during the draw,
> > tag all surfaces with the desired colorspace. Clients can still choose to
> > "convert" src images into that colorspace, or leave them as is.
> > 
> > Some rebaselines are expected, as there will be small diffs in the low-bits
> > of pixels as the two approaches (colorspacexform -vs- native-draw). Many
> > of these will be mitigated by some skia changes underway (see skia:8793)
> > 
> > Bug: skia:8773
> > Change-Id: I9b5e37a10010b1173d404009bf816cb623d0bac9
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489137
> > Commit-Queue: Mike Reed <reed@google.com>
> > Reviewed-by: weiliangc <weiliangc@chromium.org>
> > Reviewed-by: Khushal <khushalsagar@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#640426}
> 
> TBR=weiliangc@chromium.org,reed@google.com,khushalsagar@chromium.org,mtklein@google.com,brianosman@google.com
> 
> Change-Id: I533f07e6332c31a4372aedc1c3ce34eb1ca14d7d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: skia:8773
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522509
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#640616}

TBR=aboxhall@chromium.org,weiliangc@chromium.org,reed@google.com,khushalsagar@chromium.org,mtklein@google.com,brianosman@google.com

Change-Id: Ia676c3b9071b0c46fe21a32d105d5ccba78dafa0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: skia:8773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523606
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#640741}
95 files changed