| commit | f758b5add136ad589cec41b02a82dc2915b32e20 | [log] [tgz] |
|---|---|---|
| author | rbpotter <rbpotter@chromium.org> | Thu Apr 15 20:47:09 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 15 20:47:09 2021 |
| tree | c5e8530233ed71199244a9576ba9523742056f11 | |
| parent | d387d39e38aba49d6bd52ee02231aedd743ca49e [diff] |
Gcm Internals: Update to JS modules Also update this UI to match current documentation and WebUI best practices as much as possible, including: - Not using CallJavascriptFunctionUnsafe and instead using a new recommended/non-deprecated message handler base class function for interacting with JS, FireWebUIListener. - Make methods calling JS non-const. This is necessary to prepare for changing web_ui() method signature to avoid returning a non-const pointer from a const function, per guidance at [1] - Use base::Unretained for registering callbacks instead of weak_ptr_factory. [1] https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/const.md Bug: 1173575 Change-Id: Idc8bae81088b538bdf3ba7f5b027df09cab414b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2785977 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#873032}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.