[go: nahoru, domu]

cc: Adding a CommitEarlyOutReason enum to replace bool in BeginMainFrameAbort method.

The bool is confusing and has meant a bunch of tests have ended up not testing
what they thought they were testing. The new enum clearly delineates between
cases were we abort without handing the commit and when we abort because the
commit was an effective nop.

This also allows new early out reasons to be easily added.

Using a C++ "enum class" to make sure all BeginMainFrameAborted cases are
converted by preventing implicit conversion to bool. Allowed on;
https://chromium-cpp.appspot.com/

BUG=416749

Review URL: https://codereview.chromium.org/793243006

Cr-Commit-Position: refs/heads/master@{#308739}
17 files changed