commit | f84df4c788d7f16915510ce124f54a21aefc37e9 | [log] [tgz] |
---|---|---|
author | Tatiana Buldina <buldina@chromium.org> | Wed Jun 26 21:32:55 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 26 21:32:55 2019 |
tree | a4e78b312a26d6c16a8b1fa815993780fcac266c | |
parent | 5dc8d8275d412679ec971dbb63f5c16582070d39 [diff] |
[ChromeDriver] Fix takeHeapSnapshot command Return heap snapshot as a string instead of JSON object. This resolves two issues: * The snapshot sometimes uses characters not allowed by our JSON parser. * Chrome's snapshot reader is sensitive to the ordering of properties in the snapshot. Converting the snapshot into JSON object and then re-serialize into string often results in a file not loadable by the snapshot reader. Bug: chromedriver:2964, chromedriver:1616 Change-Id: Ia721c28ed78a085d567111459c9e50d8bc26f81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679224 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#672666}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .