commit | f87091c3fa531f65745a6d32e2a903660ae3458e | [log] [tgz] |
---|---|---|
author | Saman Sami <samans@chromium.org> | Mon Jun 10 19:50:53 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jun 10 19:50:53 2019 |
tree | 216784ff5d2fe6310d94c17c3d5897fcd8dbf43f | |
parent | a841c4f015f1552330879279f693e185203e520c [diff] |
Revert "Disable leaking cc_unittests on LSAN." This reverts commit de6c3d36fbafd1f2da6fb4e8bb71023e0b170626. Reason for revert: This CL disables too many tests. Only disable Vulkan tests. Original change's description: > Disable leaking cc_unittests on LSAN. > > See crrev.com/c/1590404 and the linked bug for context -- the goal is to > fix the broken memory-leak checking in Chromium's ASAN > (AddressSanitizer) trybots, which are supposed to also run LSAN > (LeakSanitizer). > > Currently-leaking tests must be fixed or disabled before leak checking > can be enabled in the ASAN trybot. > > WARNING: This will result in a loss of ASAN coverage for the affected > tests given that LSAN runs as part of the ASAN trybot. > > If that's not acceptable, we can wait until the leaks are fixed before > fixing leak detection in trybots, but keep in mind that newly-introduced > leaks Chromium-wide won't be caught until then. > > Bug: 971325 > Change-Id: Id69a4b1358a9097b4cb19106fabe4b4e591c1ca9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646072 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: Caleb Raitto <caraitto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666756} TBR=rjkroege@chromium.org,enne@chromium.org,caraitto@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 971325 Change-Id: Idf354f8fdb81d5e771332d0053adb9ca35ae168a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651886 Reviewed-by: Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#667702}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .