[go: nahoru, domu]

Revert "Disable leaking cc_unittests on LSAN."

This reverts commit de6c3d36fbafd1f2da6fb4e8bb71023e0b170626.

Reason for revert: This CL disables too many tests. Only disable Vulkan
tests.

Original change's description:
> Disable leaking cc_unittests on LSAN.
>
> See crrev.com/c/1590404 and the linked bug for context -- the goal is to
> fix the broken memory-leak checking in Chromium's ASAN
> (AddressSanitizer) trybots, which are supposed to also run LSAN
> (LeakSanitizer).
>
> Currently-leaking tests must be fixed or disabled before leak checking
> can be enabled in the ASAN trybot.
>
> WARNING: This will result in a loss of ASAN coverage for the affected
> tests given that LSAN runs as part of the ASAN trybot.
>
> If that's not acceptable, we can wait until the leaks are fixed before
> fixing leak detection in trybots, but keep in mind that newly-introduced
> leaks Chromium-wide won't be caught until then.
>
> Bug: 971325
> Change-Id: Id69a4b1358a9097b4cb19106fabe4b4e591c1ca9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646072
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Commit-Queue: Caleb Raitto <caraitto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666756}

TBR=rjkroege@chromium.org,enne@chromium.org,caraitto@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 971325
Change-Id: Idf354f8fdb81d5e771332d0053adb9ca35ae168a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651886
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667702}
diff --git a/cc/BUILD.gn b/cc/BUILD.gn
index 772e7b9..3591777 100644
--- a/cc/BUILD.gn
+++ b/cc/BUILD.gn
@@ -779,7 +779,8 @@
     # TODO(samans): Support more configurations.
     # CFI issue: https://crbug.com/967819
     # x86 issue: https://crbug.com/967831
-    if (use_x11 && target_cpu != "x86" && !is_cfi) {
+    # LSAN issue: https://crbug.com/971325
+    if (use_x11 && target_cpu != "x86" && !is_cfi && !is_lsan) {
       defines = [ "ENABLE_CC_VULKAN_TESTS" ]
     }
   }