commit | fa4062aacb8b4b442a1ab6a518d7d0d74281539e | [log] [tgz] |
---|---|---|
author | William Liu <liuwilliam@chromium.org> | Wed Feb 14 20:59:20 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 14 20:59:20 2024 |
tree | 32880fa25ee65e308f4f2fdec9ccd9cfdee1d1fc | |
parent | 49e877b4f89e00b94c40f65e21b8a80398bb4e15 [diff] |
[view-transition] Re-enable NewContentTimeoutIsSetWhenLeavingBFCacheWithViewTransition Removing the pixel comparison should make the test stable. Looking at the flaky history [1], they all failed because of the pixel comparison. TLDR: depending on when the screenshot request is served in viz (pre/post VT animation), the content of the screenshot can be either green (fallback surface) or red (primary surface). The reasons of failure are documented in https://crbug.com/40278487. [1]: https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fcontent%2Ftest%3Acontent_browsertests%2FRenderFrameHostImplBrowserTestWithBFCacheAndViewTransition.NewContentTimeoutIsSetWhenLeavingBFCacheWithViewTransition?q=V%3Abuilder%3Dandroid-pie-arm64-rel+V%3Adevice_os%3DPQ3A.190801.002+V%3Adevice_type%3Dwalleye+V%3Aos%3DAndroid+V%3Atest_suite%3Dcontent_browsertests Bug: 40278487 Change-Id: I00390d5dbaa9fcac5a27cebafefa308d3f59b7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5297674 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: William Liu <liuwilliam@chromium.org> Cr-Commit-Position: refs/heads/main@{#1260689}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.