commit | fd714c1f5cdbe98e7bf4bc47b312e648300b2496 | [log] [tgz] |
---|---|---|
author | Alan Screen <awscreen@chromium.org> | Fri Mar 24 21:03:29 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Mar 24 21:03:29 2023 |
tree | 532135f8400107d7edbf9a11cc6ef6f5122722dd | |
parent | fb290bb9d731b37befdac175c1e4bfc4ba980922 [diff] |
Alter UpdatePrintSettings API to use context ID After https://crrev.com/1117252, UpdatePrintSettings() is no longer called as a regular query for Print Preview. It is now only used prior to invoking the system print dialog or at the start of printing a document from Print Preview. This significantly changes the use case for it, as now it can always require a context ID when it is used out-of-process. This change in API requires an OOP printing context to be established earlier. It also affects StartPrinting() since the settings are now only longer needed at this time when the system print dialog is invoked from in the browser. This facilitates some cleanup, since the Mojo PrintTargetType is no longer necessary. It is now sufficient just to know if the print job is from a system dialog. Bug: 1414968 Change-Id: Ib5e50263df54b550216525dbd10a83e6ee3efff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4256086 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1121921}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.