commit | fe901037fd6ae87e8eee4efa17016ea6ca0c503b | [log] [tgz] |
---|---|---|
author | Darren Shen <shend@chromium.org> | Wed Jun 05 11:04:45 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 05 11:04:45 2019 |
tree | 51a19835f4d1da5b61505ce49ea3f908a01514ce | |
parent | 987614668e01f519f26efd85532eddec6390e63a [diff] |
ime: Revert MODECHANGE key behaviour back to original. In a previous patch, we changed the MODECHANGE key behaviour so that pressing it once will only show the current input method. This was to follow the UX specs. However, upon consideration, we're going to change it back to the original behaviour of switching to next input method on first key press. The original code used a event rewriter to convert the MODECHANGE key into Ctrl-Shift-Space (which switches to the next key press). We then changed the code to be in ash accelerators because of the extra logic involved. Now that we don't need this extra logic, we could revert back to event rewriter, but we think it's better to keep it in accelerators because we still have some extra logic around histogram logging. TBR=holte@chromium.org Bug: 953901 Change-Id: I2cf4dc41300b62ee6f57085408e199a2a55062b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642487 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#666233}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .