[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / 049975acdd1ea7b29aadcfdfca266f125f36e3cd
commit049975acdd1ea7b29aadcfdfca266f125f36e3cd[log] [tgz]
authorTrent Apted <tapted@chromium.org>Sun Jan 07 23:43:26 2018
committerCommit Bot <commit-bot@chromium.org>Mon Jan 08 22:48:16 2018
tree87639b95e9be1d13ba267448c0e69a0f446b7f5f
parent5ed1d19244d15c71c3079c9105b2c291dc91f1da [diff]
Mac: Remove the arrow from extension popups with SecondaryUiMd.

MD/Harmony bubbles have no arrows and anchor to a bottom corner of the
anchor button. BubbleDialogDelegate takes care of this for Views dialogs
but for Harmony phase 1, the extension popup doesn't need to change to
MacViews. Currently the anchor location is updated, but the bubble still
has an arrow.

Remove the arrow to make bubbles consistent. As a bonus, this actually
makes them more consistent with the NSMenu that's shown for extensions
without their own popup, which also doesn't have an arrow.

Bug: 757646
Change-Id: I868e64f2d062f9b6cbddd5c48fe9fd9539306f8f
Reviewed-on: https://chromium-review.googlesource.com/850497
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527792}
3 files changed
tree: 87639b95e9be1d13ba267448c0e69a0f446b7f5f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .