commit | 04cd1ad79a0017ad13dd28c938ee29d0d3b7e14a | [log] [tgz] |
---|---|---|
author | Maks Orlovich <morlovich@chromium.org> | Fri Jul 02 17:32:24 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 02 17:32:24 2021 |
tree | fbad72ab2b38a5846a5ade8b7f51637c998dd1a0 | |
parent | 5a5c2ed9227f0e939554db1c90f9ac8875153338 [diff] |
disk_cache: Make GetAvailableRange reasonable to use safely. Before this change, it took an out pointer parameter, which is really messy to manage destination lifetime for in a net-style method. (See the bug for a couple of different ways it could go wrong) This change it to return (and pass to callbacks) the result by value instead, which avoids the complications entirely. Bug: 1208738 Change-Id: I01f07ac693bb25266f91c3cd1ec4d69c023a1891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983259 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#898234}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.