[go: nahoru, domu]
Google Git
Sign in
chromium / chromium / src / 057867218236cc9f7b584975110eefdf2215f7ee
commit057867218236cc9f7b584975110eefdf2215f7ee[log] [tgz]
authorAustin Sullivan <asully@chromium.org>Mon Sep 25 19:26:53 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Sep 25 19:26:53 2023
tree3701788a4a80faf26f43dc96bedd6c1f586db299
parent90ba1ad60524f0fc4ff65e9a6c4f06905b21510a [diff]
Reland "FSA: Provide a better error if observe() fails"

This reverts commit 8c34999fbd695045b08f9e8dcd0bf0a285461293.

Reason for revert: Fixed failures on iOS

Original change's description:
> Revert "FSA: Provide a better error if observe() fails"
>
> This reverts commit 7a76e40f19498035d5ba24f2ceb5ec7ff7f3e34e.
>
> Reason for revert: causing failures on ios-blink-dbg-fyi
>
> Original change's description:
> > FSA: Provide a better error if observe() fails
> >
> > Before this CL, observe() would always throw a NotSupportedError, which
> > is generally reserved for unlaunched/unsupported features. Now, we'll
> > throw an OperationFailedError if observing the given file is supported,
> > but initializing the corresponding change source fails
> >
> > Bug: 1019297
> > Change-Id: I7e5bb3be14bbad4caf755ecc47ef6797df1bfacc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4883812
> > Auto-Submit: Austin Sullivan <asully@chromium.org>
> > Reviewed-by: Christine Smith <christinesm@chromium.org>
> > Commit-Queue: Christine Smith <christinesm@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1200214}
>
> Bug: 1019297
> Change-Id: I208e894ea76b68b5a5ae5e747636e25bf92a1cb1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885557
> Reviewed-by: Austin Sullivan <asully@chromium.org>
> Commit-Queue: Austin Sullivan <asully@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1200388}

Bug: 1019297
Change-Id: I35176a5069a9b8c852f08f250e364083a0f58056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885458
Reviewed-by: Christine Smith <christinesm@chromium.org>
Auto-Submit: Austin Sullivan <asully@chromium.org>
Commit-Queue: Christine Smith <christinesm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1201115}
9 files changed
tree: 3701788a4a80faf26f43dc96bedd6c1f586db299
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.