commit | 0012f7cb19971971f1d956a5b7aaf6a773091f85 | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Fri Jul 08 19:28:59 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 08 19:28:59 2022 |
tree | d8ffcb6cd659fda8229f91bed678bb3d8c6e52d4 | |
parent | 6dfae7779f5a927e0d58c7ca2487fe6e0eb84248 [diff] |
[WebUITabStrip] Crash @TabDragDropDelegate::ShouldPreventSnapToTheEdge() When performing a tab dragging, with WebUITabStrip ON, an instance of TabDragDropDelegate is created. The logic in this class relies heavily on a valid |source_window_| class member, passed in as ctor parameter. When, during a drag drop operation, this |source_window_ object is destroyed, UAF crashes can happen in many places in TabDragDropDelegate. This CL makes use of a WindowObserver installed in DragDropController to cease the operation of its TabDragDropDelegate instance, when the respective |source_window_| is destroyed. BUG=1286203 R=oshima@chromium.org Change-Id: I3d59017945d5b3e01eaf31de7d38b2898e660d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747280 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/main@{#1022261}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.