| commit | 008ea7cd86ea3ef434112b0bda55bd82a81e93a7 | [log] [tgz] |
|---|---|---|
| author | Joanmarie Diggs <jdiggs@igalia.com> | Mon Sep 12 20:22:34 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 12 20:22:34 2022 |
| tree | 15b272a978d39f5f72255a2f305e2e3cdd8b16b4 | |
| parent | 73ceff08f74531aea308e9900f810088fac2b589 [diff] |
Enforce valid role prior to calling AXNodeData::SetName Callers are expected to set a valid role prior to calling SetName. We check for Role::kNone (the role was explicitly changed to the presentational role) but not Role::kUnknown (the role was never set / AKA the default). This commit adds Role::kUnknown to the existing DCHECK and sets roles on several Views which were missing roles. AX-Relnotes: n/a Bug: 1348081 Change-Id: I7511fbdfdc78944978641d19e94f368dc6d72fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3816142 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#1045987}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.