commit | 0a04c812ca3afb3e0b76eba836db02a90ab2591c | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Tue Jul 24 15:46:28 2018 |
committer | Rayan Kanso <rayankans@chromium.org> | Tue Jul 24 15:46:28 2018 |
tree | e5d63e698d3eaf025ee9fdba58a26a17dc398a41 | |
parent | c3b0effbe9f638243dae263af97794bf010170c1 [diff] |
Revert "Reland "[Background Fetch] Move all updatable UI options to their own proto."" This reverts commit 9311d41253fc74d49527fb2ee69e0363334b969d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577500 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzMTFkNDEyNTNmYzc0ZDQ5NTI3ZmIyZWU2OWUwMzYzMzM0Yjk2OWQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/41118 Sample Failed Step: viz_content_unittests Original change's description: > Reland "[Background Fetch] Move all updatable UI options to their own proto." > > This is a reland of d3981964f2499033059aae600732d656370e0ddf > > TBR=avi@chromium.org > > Original change's description: > > [Background Fetch] Move all updatable UI options to their own proto. > > > > Bundle up the icon and the title since they will be accessed/modified > > together in the updateUI call. > > > > It also makes sense to move the icon from the metadata proto since that > > will speed up getting the registration info. > > > > TBR=avi@chromium.org > > > > Bug: 865063 > > Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 > > Reviewed-on: https://chromium-review.googlesource.com/1146650 > > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Peter Beverloo <peter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577272} > > Bug: 865063 > Change-Id: I77567e8e2e0ea59ede514c77b40326e7ece48a25 > Reviewed-on: https://chromium-review.googlesource.com/1148261 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577500} Change-Id: I60aa46070806c053cc60d77b32456d192de378c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865063 Reviewed-on: https://chromium-review.googlesource.com/1148500 Cr-Commit-Position: refs/heads/master@{#577559}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .