commit | 0a18f154cc8d2470deb71b838cdbcab537116317 | [log] [tgz] |
---|---|---|
author | Dan McArdle <dmcardle@chromium.org> | Thu Feb 01 18:50:19 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 01 18:50:19 2024 |
tree | 42edd9acfd9d9cd968636ba55284da4c4a065a06 | |
parent | 4cadb907d2b905ddaeec51eb6d57f850489b66c6 [diff] |
Address clang-tidy findings in //content/browser/interest_group * Prevent UB division by zero with a CHECK. Perhaps impossible at runtime, but I am choosing to be pedantic. https://timsong-cpp.github.io/cppwp/n4659/expr.mul * Fix accidental use-after-move in InterestGroupAuctionReporter constructor. Not sure if the behavior is defined. * Some return values are currently only used when DCHECK is enabled. Style guide prefers CHECK anyway, so I'm upgrading the DCHECKs to CHECKs rather than adding [[maybe_unused]] annotations. Relevant section from chromium C++ style guide: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md#check_dcheck_notreached_noreturn_and-notreached Change-Id: Idef64ef13fe1b7fc386f6b102bc81f9513ffb0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5254560 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255166}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.