commit | 16955aaed22717b5900268d38552282885865cc2 | [log] [tgz] |
---|---|---|
author | Adam Rice <ricea@chromium.org> | Mon Mar 01 13:57:55 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 01 13:57:55 2021 |
tree | b5f297547d07599033514c9e371a92c299e87490 | |
parent | 901be786de6bcc5c845cdc0e82f028bd8c9a39f4 [diff] |
WebSocket over H2: Detect stream close correctly Previously WebSocket over HTTP/2 didn't handle the case when a server half-closes the stream after sending the Close frame correctly. It would fail to detect the half-close and timeout after 2 seconds, considering the close to be unclean. Modify WebSocketSpdyStreamAdapter::OnDataReceived to close the stream when a half-close is detected. Also modify SpdyStream to notify its delegate when a half close is detected. This was already the documented behaviour. BUG=1151393 Change-Id: I668d6ae0dc5a3926efade1c28f16ca379f5b1566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2721519 Auto-Submit: Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#858542}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.