commit | 11a986346eb98aa7e5831fe4dc68d354215bea9f | [log] [tgz] |
---|---|---|
author | mlcui <mlcui@google.com> | Tue Jun 25 00:42:46 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 25 00:42:46 2024 |
tree | 459e3e6467ad1c04687dc16f7b261fd1c90998cd | |
parent | 933f528786d5cb0171997aa3b4656f1b91d19f45 [diff] |
Refactor search start members in request to map This actually uses a std::array as suggested by dcheng@'s Slack comment [1]. This will help us know how many searches are started (i.e. the number of non-null entries in `search_starts_`. However, GIF searches are technically not started until after burn-in. This is also technically a behavioural change - the query time metrics now "end" at right before the search request calls `current_callback_`. Previously, the query time metrics "ended" as soon as possible after the response from the search source arrives, before preprocessing. This mainly affects CrOS search results, which truncate the search results before calling `current_callback_`. [1]: https://chromium.slack.com/archives/CGGKQ3KA9/p1695749305687779 Bug: b:348067874 Change-Id: I6a6a210068966b40ddd8fc5aae2033112b162f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645091 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#1318894}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.