[go: nahoru, domu]

Reland "Reland "ozone/drm: Render primary framebuffers as RGBA""

This reverts commit 7c475ee71ef38604a435b9027dd47d8462337344.

Reason for revert: We've fixed the issue where eglCreateImageKHR fails with ARGB+AFBC and reverted CL:985033 which enabled blending for the lowest order plane, which doesn't work everywhere.

Original change's description:
> Revert "Reland "ozone/drm: Render primary framebuffers as RGBA""
> 
> This reverts commit 292706dad68802d7eb6402799586e036d97739d1.
> 
> Reason for revert: breaks RK3399, where we don't have ARGB+AFBC support yet:
> 
>   https://bugs.chromium.org/p/chromium/issues/detail?id=826973
> 
> once
> 
>   https://chrome-internal-review.googlesource.com/c/chromeos/vendor/mali-ddk/+/597023
> 
> lands we can reland.
> 
> Original change's description:
> > Reland "ozone/drm: Render primary framebuffers as RGBA"
> > 
> > This is a reland of 48d1ecafe170a41e0e1eee736370f0f56f9e3e93
> > 
> > With CL:967415 and CL:964984, we've fixed the issues where RGBA
> > framebuffers slipped through to KMS on devices without RGBA support.
> > 
> > Original change's description:
> > > ozone/drm: Render primary framebuffers as RGBA
> > >
> > > In preparation for hardware plane underlay support in ChromeOS, we
> > > need to allow for RGBA primary framebuffers. When using an underlay,
> > > we cut out a transparent rectangle in the primary framebuffer to allow
> > > the underlay to show through, while still allowing for RGBA content on
> > > top of the underlay (for example, video controls or annotations).
> > > When not using an underlay, the primary framebuffer will be displayed
> > > as RGBX (opaque) to avoid unnecessary blending in the display
> > > controller.
> > >
> > > Bug: 789288
> > > Change-Id: I2fc94e524e250ec9b7e11cd6801e1c8308046a10
> > > Reviewed-on: https://chromium-review.googlesource.com/801974
> > > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
> > > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> > > Reviewed-by: David Reveman <reveman@chromium.org>
> > > Reviewed-by: danakj <danakj@chromium.org>
> > > Reviewed-by: Antoine Labour <piman@chromium.org>
> > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> > > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#542877}
> > 
> > TBR: piman
> > Bug: 789288
> > Change-Id: Ie1032615d8970c6a74f354ad78c30679706e40ed
> > Reviewed-on: https://chromium-review.googlesource.com/975782
> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> > Reviewed-by: David Reveman <reveman@chromium.org>
> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#545503}
> 
> TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 789288
> Change-Id: I980fb2dda940cf0b9bdfbdb8b88c2c519f5e9f85
> Reviewed-on: https://chromium-review.googlesource.com/985255
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546734}

TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,alemate@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 789288
Change-Id: I8c98951eff5db24ed7066694b18eb00043b63c27
Reviewed-on: https://chromium-review.googlesource.com/988673
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547318}
6 files changed