commit | 12bd222001abb95beca4ef447e80a466fdb82c26 | [log] [tgz] |
---|---|---|
author | Xiaohan Wang <xhwang@chromium.org> | Thu May 19 15:38:02 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu May 19 15:38:02 2022 |
tree | bb1137a2d63951564bbf0e9f0836e543b2ce34c4 | |
parent | 0eaf1c28a85a2c6166a1821fc76a13d8c94f60a4 [diff] |
base: Add `reply_callback` for GetDeleteFileCallback() Currently since GetDeleteFileCallback() has retry logic on Windows, there's a risk of accessing files in the path while it's still being deleted (or to be deleted in the next retry). This could cause access issues, or file/data corruption and is unsafe. This CL updates GetDeleteFileCallback() to take an additional reply callback, so that when the callback is run, the caller is sure that the operation has finished, and even better, to know whether it succeeded or failed. Same change for GetDeletePathRecursivelyCallback(), even though it does not support retry yet, which will be done in the next CL. Bug: 1321695 Change-Id: I75feb5df153eb6512d8655f897737cff9617dc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3632646 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005255}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.