commit | 134e9e5c7baa05c49592924b1040465c04313419 | [log] [tgz] |
---|---|---|
author | Peter Kasting <pkasting@chromium.org> | Thu Feb 01 19:23:39 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 01 19:23:39 2024 |
tree | fcc81235ff610f447ccbf233156e2893d172b022 | |
parent | ae89e68356ee4c63b4691b799d616cf293cc90f2 [diff] |
Lock down access to LayoutSuperclass<>() and verify protections. It's not possible to enforce at compile-time that LayoutSuperclass<>() is only called while a layout is being processed, so enforce that at runtime instead, and verify that enforcement with a death test. This also adds nocompile tests that verify the PassKey protections on Layout(). As a result, it should be impossible to improperly Layout() directly from tests, so the presubmits blocking that are removed. Bug: 1521108 Change-Id: I8f7653c7bdcbbebe5e042310028b3f7de691614f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259737 Reviewed-by: Dominic Battre <battre@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255197}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.