commit | 1c0542a7b3f4e926760d2bb743e19fc4724c47fd | [log] [tgz] |
---|---|---|
author | Daniel Cheng <dcheng@chromium.org> | Mon Sep 26 18:37:51 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 26 18:37:51 2022 |
tree | 8b4e4fd010f975d79e99516556e7a0ead673529e | |
parent | bfc0def95982776287fb31c04001cef0bfcb7796 [diff] |
Use helper macros to define base::Features in //chromeos This allows: - features to be defined with a consistent set of qualifiers, and for that set of qualifiers to be updated over time as appropriate. - better PRESUBMIT checks to ensure that base::Features are not defined in headers. - simplifies things for scripts trying to extract feature definitions out of C++ code. One manual fix was required for a feature that specified the export attribute on the definition rather than the declaration. While legal, it is far more common to specify the export attribute on the declaration. Bug: 1364289 Change-Id: I5f43c979e1b46313109ebdcc9199b804aeba92eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3916971 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#1051318}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.