commit | 1cde40e66f3e7e16768c259e760767a354c79e06 | [log] [tgz] |
---|---|---|
author | David Bokan <bokan@chromium.org> | Fri Feb 02 14:54:50 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 02 14:54:50 2024 |
tree | b29e080f1abf55df84f6f763358197940ece88a9 | |
parent | 10b2676e2ad1ddf9c18f9367418d3890bd100e81 [diff] |
Avoid CHECKing for missing scrollable area It seems the node/layout_object returned from a hit test is sometimes not the one we used to hit test a scrollable area. Not sure how this happens but we should avoid crashing in this case and return null which will just use style from the hit layout object to style a cursor (which is what was done prior to https://crrev.com/a7b66a751c2ed55). I'll add crash keys to debug this in a followup. Bug: 1519197 Change-Id: I2afe75f9ce7287492bb5e80677b6dc3cb603582d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259180 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255556}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.