[go: nahoru, domu]

Revert "Resources#getColor errorprone plugin."

This reverts commit b6339fc4d21bd10ffd985be4e1afe2a135823755.

Reason for revert: Broke downstream builds, see https://ci.chromium.org/ui/p/chrome/builders/ci/android-arm-rel-ready/12653/overview

Original change's description:
> Resources#getColor errorprone plugin.
>
> Bug: 1302803
> Change-Id: I396b8fb7739575e6dafd578335642b4498d84e1d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5096200
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1234671}

Bug: 1302803
Change-Id: I584c3d41e9fb40452a8ebbe3607bf511ead6ab68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5101449
Auto-Submit: Sky Malice <skym@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Owners-Override: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234697}
diff --git a/tools/android/errorprone_plugin/BUILD.gn b/tools/android/errorprone_plugin/BUILD.gn
index b5860c473..83e128e 100644
--- a/tools/android/errorprone_plugin/BUILD.gn
+++ b/tools/android/errorprone_plugin/BUILD.gn
@@ -16,7 +16,6 @@
     "src/org/chromium/tools/errorprone/plugin/NoAndroidAsyncTaskCheck.java",
     "src/org/chromium/tools/errorprone/plugin/NoDynamicStringsInTraceEventCheck.java",
     "src/org/chromium/tools/errorprone/plugin/NoRedundantFieldInitCheck.java",
-    "src/org/chromium/tools/errorprone/plugin/NoResourcesGetColor.java",
     "src/org/chromium/tools/errorprone/plugin/NoSynchronizedMethodCheck.java",
     "src/org/chromium/tools/errorprone/plugin/NoSynchronizedThisCheck.java",
     "src/org/chromium/tools/errorprone/plugin/TestClassNameCheck.java",
diff --git a/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoResourcesGetColor.java b/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoResourcesGetColor.java
deleted file mode 100644
index f136341..0000000
--- a/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/NoResourcesGetColor.java
+++ /dev/null
@@ -1,54 +0,0 @@
-// Copyright 2023 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.tools.errorprone.plugin;
-
-import static com.google.errorprone.matchers.Matchers.instanceMethod;
-
-import com.google.auto.service.AutoService;
-import com.google.errorprone.BugPattern;
-import com.google.errorprone.BugPattern.LinkType;
-import com.google.errorprone.BugPattern.SeverityLevel;
-import com.google.errorprone.VisitorState;
-import com.google.errorprone.bugpatterns.BugChecker;
-import com.google.errorprone.bugpatterns.BugChecker.MethodInvocationTreeMatcher;
-import com.google.errorprone.matchers.Description;
-import com.google.errorprone.matchers.Matcher;
-import com.google.errorprone.suppliers.Suppliers;
-import com.sun.source.tree.ExpressionTree;
-import com.sun.source.tree.MethodInvocationTree;
-
-/** Assert {@link android.content.res.Resources#getColor(int)} is not used. */
-@AutoService(BugChecker.class)
-@BugPattern(
-        name = "NoResourcesGetColor",
-        summary =
-                "Use android.content.Context#getColor instead of"
-                        + " android.content.res.Resources#getColor.",
-        severity = SeverityLevel.SUGGESTION,
-        linkType = LinkType.CUSTOM,
-        link = "http://crbug.com/1302803")
-public class NoResourcesGetColor extends BugChecker implements MethodInvocationTreeMatcher {
-    private static final String CLASS_NAME = "android.content.res.Resources";
-    private static final String METHOD_NAME = "getColor";
-
-    // Allow Resources#getColor(int, Theme) on purpose as an easy escape hatch for this check, and
-    // it does correctly handle themes/dynamic colors.
-    private static final Matcher<ExpressionTree> CONTEXT_MATCHER =
-            instanceMethod()
-                    .onDescendantOf(Suppliers.typeFromString(CLASS_NAME))
-                    .named(METHOD_NAME)
-                    .withParameters(int.class.getName());
-
-    @Override
-    public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState visitorState) {
-        if (CONTEXT_MATCHER.matches(tree, visitorState)) {
-            return buildDescription(tree)
-                    .setMessage("Don't use Resources#getColor - call Context#getColor instead")
-                    .build();
-        } else {
-            return Description.NO_MATCH;
-        }
-    }
-}
diff --git a/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/OWNERS b/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/OWNERS
deleted file mode 100644
index 74ab83d..0000000
--- a/tools/android/errorprone_plugin/src/org/chromium/tools/errorprone/plugin/OWNERS
+++ /dev/null
@@ -1 +0,0 @@
-per-file NoResourcesGetColor.java=skym@chromium.org
\ No newline at end of file