| commit | 2409ec4329d8a4c4db14d47a6a0ca3ebc82c5093 | [log] [tgz] |
|---|---|---|
| author | Luciano Pacheco <lucmult@chromium.org> | Thu Jan 21 06:56:35 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 21 06:56:35 2021 |
| tree | e53fa0ffd34ec4c8f2259c7e8ceab414c7da58fc | |
| parent | 5918ed4438ec3c9be1812f96e9e9887a8eca0204 [diff] |
Files app: Fix broken images when running as JS Modules. When running as non-js-modules the <bread-crumb> has its images in-lined by grit, however when running as JS modules the <bread-crumb> is in-lined via rollup, then it runs from the path foreground/js/ instead of its actual path foreground/js/ui/ making the relative address to its images incompatible. Fix by duplicating the 2 affected images, moving them up 1 directory so the relative path is consistent. NOTE: These 2 images are the only references to "/images" inside the ui/ directory. [1] [1] - https://source.chromium.org/search?q=%22images%2F%22&sq=&ss=chromium%2Fchromium%2Fsrc:ui%2Ffile_manager%2Ffile_manager%2Fforeground%2Fjs%2Fui%2F Bug: 1133186 Change-Id: I71a10286c325e54c3adecc0f079002aeab7a0344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640006 Reviewed-by: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845547}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.