[go: nahoru, domu]

Reland "Reland "build/toolchain: check existence of reclient configs in GN""

This reverts commit 2363d9d2beb8e167cdac669c4ac153f2d0a25dee.

Reason for revert:
Fix for previous breakage was made as https://crrev.com/c/4941335.

Original change's description:
> Revert "Reland "build/toolchain: check existence of reclient configs in GN""
>
> This reverts commit 22acd2f1adc9cb01c0b55bf760b3f991e30f0706.
>
> Reason for revert: crbug/1492504 - Breaks chrome.ci/ci/win64-builder-perf
>
> Original change's description:
> > Reland "build/toolchain: check existence of reclient configs in GN"
> >
> > This reverts commit 4a2851adac4fd9c83cf2ed985f16c144e55c15d7.
> >
> > Reason for revert:
> >
> > Fix path in `file_dependencies` to avoid the error from `gn gen` when
> > that is ran from
> > https://source.chromium.org/chromium/chromium/src/+/main:build/android/test/incremental_javac_gn/incremental_javac_test_android_library.py
> >
> > rbe_cc_cfg_file is already rebased on root_build_dir, but paths in
> > `file_dependencies` also seem to be rebased on directory of
> > `build/toolchain/rbe.gni` automatically. So need to fix the path passed
> > to `file_dependencies` in exec_script.
> >
> > Original change's description:
> > > Revert "build/toolchain: check existence of reclient configs in GN"
> > >
> > > This reverts commit 743eba2dfd72a422a816f8d1eb948f83e48c2fae.
> > >
> > > Reason for revert:
> > > LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8767373823290641361
> > >
> > > Sample failed build: https://ci.chromium.org/b/8767373823290641361
> > >
> > > If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8767373823290641361&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4930333
> > >
> > > Original change's description:
> > > > build/toolchain: check existence of reclient configs in GN
> > > >
> > > > This is to show user friendly message when user forget to set
> > > > download_remoteexec_cfg in .gclient.
> > > >
> > > > ref: https://gn.googlesource.com/gn/+/refs/heads/main/docs/reference.md#func_exec_script
> > > >
> > > > Bug: b/303174319
> > > > Change-Id: Ic3499a100ab197ea4794bcec4727b92a44ed7785
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4930333
> > > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > > Reviewed-by: Fumitoshi Ukai <ukai@google.com>
> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > > > Cr-Commit-Position: refs/heads/main@{#1209256}
> > > >
> > >
> > > Bug: b/303174319
> > > Change-Id: I3658b0f145d96a00d54dfd3d0a63554b4240c581
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4937971
> > > Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
> > > Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
> > > Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
> > > Cr-Commit-Position: refs/heads/main@{#1209270}
> >
> > Bug: b/303174319
> > Change-Id: I101bdd008b2e6e999b98d894776b16db87ecc989
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4937397
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Junji Watanabe <jwata@google.com>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1209326}
>
> Bug: b/303174319
> Change-Id: I016302e4829b257ab85499666e57f4d1b248a807
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4939373
> Commit-Queue: Jeff Yoon <jeffyoon@google.com>
> Auto-Submit: Jeff Yoon <jeffyoon@google.com>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1209624}

Bug: chromium:1492504 b/303174319
Change-Id: I21c44f4a492df4290359ec109f368060a22e3494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4941520
Reviewed-by: Junji Watanabe <jwata@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210618}
3 files changed
tree: 888862281f427297929d57b4cc8b07458bbf5dea
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.