| commit | 25e7f8dd30df84d488c1eba184edd2b5825681b4 | [log] [tgz] |
|---|---|---|
| author | Ovidio Henriquez <odejesush@chromium.org> | Thu May 02 01:37:17 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu May 02 01:37:17 2019 |
| tree | 9c98ab3b23489e0b164eaeffb14f4af8e43853dc | |
| parent | ac054d17e66d6aa13003d3d661da472563612131 [diff] |
Reland "Reland "bluetooth: FakeBluetoothChooser impl."" This is a reland of cb85732cb3be7cf442e5c3afe6a3625f7edee10b The previous change caused the WebKit Linux Trusty ASAN trybot to fail because the FakeBluetoothChooser mojom JS file was not included when the blink_web_tests_exparchive target was isolated. Bug: 957867 TBR=ortuno@chromium.org Original change's description: > Reland "bluetooth: FakeBluetoothChooser impl." > > This is a reland of 6a337f19713e049cd42969b0c909c59aff4146cd > > This previous change caused tests to fail because of a Mojo validation > error, which is now taken care of by allowing the Bluetooth tests to > use the path to the generated Mojom files. > > Design doc: > https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg > > Original change's description: > > bluetooth: FakeBluetoothChooser impl. > > > > Implements the interfaces that FakeBluetoothChooser overrides. The > > mojom::FakeBluetoothChooser overrides are implemented by running > > |event_handler_| with the appropriate arguments. The BluetoothChooser > > overrides do nothing at the moment, since the base class is only meant > > to update the chooser user interface. > > > > This change also begins to partially convert a Bluetooth chooser test to test > > the interface and deletes the temporary tests that were created to test this > > API. > > > > This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which > > reverted the original change. The original change caused the > > new-scan-device-added.html test to fail because of a Mojo validation error > > resulting from not updating the > > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js > > file needed by the test. > > > > Bug: 719827, 719826, 824704, 826787 > > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527 > > Reviewed-on: https://chromium-review.googlesource.com/985195 > > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#546729} > > Bug: 719827, 719826, 824704, 826787 > Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/986593 > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#655081} Bug: 719827, 719826, 824704, 826787 Change-Id: Iaddf24a659573d3815c9c004f6fb05a41c446616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589845 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#655869}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .