commit | 2859b9557124b94d8a8ec5104c71f2bbab006935 | [log] [tgz] |
---|---|---|
author | Edmund Wright <edmundw@google.com> | Fri Feb 09 18:49:59 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Feb 09 18:49:59 2024 |
tree | ed6a13e7986b36e2c8dcbca32c9c23fab352269a | |
parent | f62990fb134b7e610502b6804945debaa51960a5 [diff] |
[gbb-cct] Fix bug where PIH comes back in broken state after being suppressed due to other bottom sheet. If while PIH is in peek state you trigger another bottom sheet, the PIH sheet is hidden. Then when the other sheet is hidden, the PIH state is restored. This currently doesn't work as intended: PIH is reappearing in expanded state (even though it was in peek before), and with no content within it (see demo video in bug). This is due to various assumptions being made in our code around the lifecycle of the sheet, and these assumptions being broken by the sheet being restored when another sheet is dismissed. For now we fix this by removing the restoration logic. If in the future we decide it's important for it to be restored then we can look into bringing this logic back in a non-broken way. Bug: 324573154 Change-Id: I675c08e92d32f47b9d80b29373fce9b2d2ca3a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280745 Auto-Submit: Edmund Wright <edmundw@google.com> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1258644}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.