commit | 20929cd9a81decb49044eabe5dabfa3327b980c1 | [log] [tgz] |
---|---|---|
author | Din Nezametdinov <shaikhitdin@google.com> | Tue Mar 05 11:30:37 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 05 11:30:37 2024 |
tree | 66dc5b64402c78e741adc2b87ba30ebad7e64c09 | |
parent | 59c5faeadae2870fcd2cd776717395267059e231 [diff] |
[Passwords] Don't do password leak check if it can't be muted The filed bug report contained several problems: 1) Password leak check ignored broken `PasswordStore`. `PasswordStore` stored if any leak notification was already shown to the user and allowed to show the leak notification at most once. Since `PasswordStore` was broken, the user was prompted with password leak every time they login to the website. 2) If the saving was disabled, form manager was not cleared and this meant that every website navigation was form submission. This lead to Password Manager prompting leaked password dialog on every navigation. Move password leak check after checking that password store is available for write and clear the submitted form even if saving is disabled. (cherry picked from commit 01f4347a31d0cabfe12e00717f757c64c5d49aa7) Bug: b/327621222 Change-Id: Ic43c34f33b0315ae645affee3b5398ecc221007a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317876 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Din Nezametdinov <shaikhitdin@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1264635} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340376 Auto-Submit: Din Nezametdinov <shaikhitdin@google.com> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#387} Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.