[go: nahoru, domu]

[Passwords] Don't do password leak check if it can't be muted

The filed bug report contained several problems:

1) Password leak check ignored broken `PasswordStore`. `PasswordStore`
stored if any leak notification was already shown to the user and
allowed to show the leak notification at most once. Since
`PasswordStore` was broken, the user was prompted with
password leak every time they login to the website.

2) If the saving was disabled, form manager was not cleared and this
meant that every website navigation was form submission.

This lead to Password Manager prompting leaked password dialog on
every navigation.

Move password leak check after checking that password store is
available for write and clear the submitted form even if saving is
disabled.

(cherry picked from commit 01f4347a31d0cabfe12e00717f757c64c5d49aa7)

Bug: b/327621222
Change-Id: Ic43c34f33b0315ae645affee3b5398ecc221007a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317876
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Din Nezametdinov <shaikhitdin@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1264635}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340376
Auto-Submit: Din Nezametdinov <shaikhitdin@google.com>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/6312@{#387}
Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
2 files changed
tree: 66dc5b64402c78e741adc2b87ba30ebad7e64c09
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.