commit | 34efeb87793cd02a9d9022a983be69a475beb8ce | [log] [tgz] |
---|---|---|
author | Arthur Sonzogni <arthursonzogni@chromium.org> | Thu Aug 17 12:55:11 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 17 12:55:11 2023 |
tree | 4db548a4c6161db8aad84f3f1b1d310c21bd2b0f | |
parent | 963d4e1663c715773036b98d0f3c8ebc6bd7abf1 [diff] |
Automatically annotate dangling ExperimentalAsh pointers [9/N] This patch is: - Automated. See [automation] section. - Not affecting users, only Chrome's CQ. See [no-op] section. This is a split affecting: - ash/ - chrome/browser/ui/ash/ Context: -------- @bartekn is going to remove the `ExperimentalAsh` raw_ptr annotation. This was a performance experiment to enable/disable MiraclePtr on a subset of new pointers added for ChromeOS ash (non-lacros). Before removing it, he needs to enable it by default in code. Enabling MiraclePtr for them, causes the DanglingPointerDetector to be enforced. To pass the CQ, we need to annotate pre-existing dangling pointer with `DanglingUntriaged`. After enabling ExperimentalAsh feature, it won't be allowed anymore for those pointers to become dangling. Automation: ----------- 1. Enable the `PartitionAllocBackupRefPtrForAsh` feature flag. 2. Apply the 'annotator' CL: https://chromium-review.googlesource.com/c/chromium/src/+/4474553 3. Run all the gtests. See https://docs.google.com/document/d/1AMMERcqy0eafFWopUCHYsIKIKEp3J8DFxqW9UIbzIHo 4. Concatenate all the output_*, `filter`, `sort -nr`, `uniq`. 5. Run https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit 6. Run `git cl format` 7. Cherry-pick the patch created from (5) no-op: ------ The DanglingPointerDetector is not enabled against users. It only affects tests and chromium developers. Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome AX-Relnotes: n/a. Bug: chromium:1441101 Change-Id: I346841ef3e72f8e7aca16a41f60fb60c46834e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780711 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1184666}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.