[go: nahoru, domu]

Automatically annotate dangling ExperimentalAsh pointers [9/N]

This patch is:
- Automated. See [automation] section.
- Not affecting users, only Chrome's CQ. See [no-op] section.

This is a split affecting:
- ash/
- chrome/browser/ui/ash/

Context:
--------
@bartekn is going to remove the `ExperimentalAsh` raw_ptr annotation.
This was a performance experiment to enable/disable MiraclePtr on a
subset of new pointers added for ChromeOS ash (non-lacros).

Before removing it, he needs to enable it by default in code. Enabling
MiraclePtr for them, causes the DanglingPointerDetector to be enforced.
To pass the CQ, we need to annotate pre-existing dangling pointer with
`DanglingUntriaged`. After enabling ExperimentalAsh feature, it won't be
allowed anymore for those pointers to become dangling.

Automation:
-----------
1. Enable the `PartitionAllocBackupRefPtrForAsh` feature flag.
2. Apply the 'annotator' CL: https://chromium-review.googlesource.com/c/chromium/src/+/4474553
3. Run all the gtests. See https://docs.google.com/document/d/1AMMERcqy0eafFWopUCHYsIKIKEp3J8DFxqW9UIbzIHo
4. Concatenate all the output_*, `filter`, `sort -nr`, `uniq`.
5. Run https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit
6. Run `git cl format`
7. Cherry-pick the patch created from (5)

no-op:
------
The DanglingPointerDetector is not enabled against users. It only
affects tests and chromium developers.

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
AX-Relnotes: n/a.
Bug: chromium:1441101
Change-Id: I346841ef3e72f8e7aca16a41f60fb60c46834e06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780711
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1184666}
417 files changed
tree: 4db548a4c6161db8aad84f3f1b1d310c21bd2b0f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.