commit | 30d2c2cffde173a140d94a57d14f8a4b4dfd2a22 | [log] [tgz] |
---|---|---|
author | Mohannad Farrag <aymanm@google.com> | Wed Feb 14 18:27:28 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 14 18:27:28 2024 |
tree | 41d4c311d9710eeb1ebfde4760319497048b695e | |
parent | 09bba705ff9f1173feed4cc86736016f432ffd89 [diff] |
Reland "Refactor check_cronet_dependencies" This reverts commit 5117e1f59060110c252cf7835503a89fa2f462cc. Reason for revert: Fixed by https://chromium-review.googlesource.com/c/chromium/tools/build/+/5285414 Original change's description: > Revert "Refactor check_cronet_dependencies" > > This reverts commit 89afd9f9793764c19ab7c84024881a25c913757a. > > Reason for revert: Breaking all our internal builders - https://ci.chromium.org/p/chrome/g/internal.client.cronet/console > > Original change's description: > > Refactor check_cronet_dependencies > > > > * check_cronet_dependencies was complicated for reasons that > > are no longer true, This simplifiess the code a lot in order to > > build upon it for androidx restrictions. > > > > * Moved some code around from python files to utils as they > > are used in plenty of different places and reduce redundancy. > > > > * I will be writing tests for the python code in the upcoming CLs. > > > > Bug: 1523205 > > Change-Id: Ic8a76203a45372f0ca74e84000033a518603e9e2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5261960 > > Reviewed-by: Stefano Duo <stefanoduo@google.com> > > Commit-Queue: Mohannad Farrag <aymanm@google.com> > > Auto-Submit: Mohannad Farrag <aymanm@google.com> > > Cr-Commit-Position: refs/heads/main@{#1258428} > > Bug: 1523205 > Change-Id: I4808febd8fd2d13ca621eee444004c252e033bad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5282388 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Chidera Olibie <colibie@google.com> > Reviewed-by: Stefano Duo <stefanoduo@google.com> > Cr-Commit-Position: refs/heads/main@{#1259090} Bug: 1523205 Change-Id: I17e932c4d9ea88073806749830cd96901d508e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5285415 Commit-Queue: Mohannad Farrag <aymanm@google.com> Reviewed-by: Chidera Olibie <colibie@google.com> Cr-Commit-Position: refs/heads/main@{#1260571}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.