Reland(2): memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest
This reverts commit 31b7833922c241a5495b1c42af67ca9503cdb65d.
Reason for reland: Fixed TestBackgroundTracingSetup flakiness, this
time for real. In the last reland I forgot to git stash pop the actual
fix and ended up just relanding the original CL as-is.
Original change's description:
> Revert "Reland: memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest"
>
> This reverts commit 05755b0fb4e7437150ab60375739e2cf8b0b3aed.
>
> Reason for revert: Failing frequently on linux_chromium_asan_rel_ng on the CQ. Has failed once so far on CI: https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/36356
>
> Original change's description:
> > Reland: memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest
> >
> > This reverts commit ac66f89e4be521caa45a972b20e7890992901469.
> >
> > Reason for reland: Fixed race in the test
> >
> > Original change's description:
> > > Revert "memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest"
> > >
> > > This reverts commit 16e1788871253de5241941eaeb0a5fdb34b3d21f.
> > >
> > > Reason for revert: MemoryDumpManagerTest.TestBackgroundTracingSetup fails under LSAN: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/36339
> > >
> > > Original change's description:
> > > > memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest
> > > >
> > > > This CL changes the memory-infra unittests to not depend on
> > > > the RequestGlobalDump() API. From a logical viewpoint,
> > > > the RequestGlobalDump() is not needed for an in-process-only
> > > > test like MemoryDumpManagerTest.
> > > > From a more practical viewpoint, this refactoring is required
> > > > in preparation of the next CLs that will remove
> > > > MemoryDumpManager::RequestGlobalDump() method and move all the
> > > > clients to directly use the service.
> > > >
> > > > This CL doesn't cause any behavior change in memory-infra.
> > > >
> > > > BUG=720352
> > > > TBR=thakis
> > > >
> > > > Change-Id: I82ee1bf94dab55798be727f0ae70a1fede6634ca
> > > > Reviewed-on: https://chromium-review.googlesource.com/525534
> > > > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > > > Reviewed-by: siddhartha sivakumar <ssid@chromium.org>
> > > > Reviewed-by: Helen Li <xunjieli@chromium.org>
> > > > Reviewed-by: Hector Dearman <hjd@chromium.org>
> > > > Commit-Queue: siddhartha sivakumar <ssid@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#477851}
> > >
> > > TBR=thakis@chromium.org,primiano@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > BUG=720352
> > >
> > > Change-Id: I7088bd3549c3a8a733d4b87226593209bd40c42e
> > > Reviewed-on: https://chromium-review.googlesource.com/528032
> > > Reviewed-by: Sam McNally <sammc@chromium.org>
> > > Commit-Queue: Sam McNally <sammc@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#477875}
> >
> > TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org
> >
> > Change-Id: Ic6439b97024d65d19012133171249dddd2de8b88
> > Reviewed-on: https://chromium-review.googlesource.com/528098
> > Commit-Queue: Primiano Tucci <primiano@chromium.org>
> > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#477988}
>
> TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
>
> Change-Id: I0e9f5a6f930e096406ac0d46ac310ef2fae99370
> Reviewed-on: https://chromium-review.googlesource.com/528513
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#478109}
TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org,jbudorick@chromium.org
Change-Id: I7493014373569281e84049cb6fdca987fc9ee83e
Reviewed-on: https://chromium-review.googlesource.com/530311
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478623}7 files changed