commit | 33e6323636432acf6cd65b985aa50550b5d73702 | [log] [tgz] |
---|---|---|
author | Xianzhu Wang <wangxianzhu@chromium.org> | Sat Dec 24 18:30:37 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Dec 24 18:30:37 2022 |
tree | e2867988fd58776cdc02439aaffb153c786f0055 | |
parent | 0b83bd93b95cefeb76f776d865965d845677867e [diff] |
Refactor SaveLayer and SaveLayerAlpha For cc::PaintCanvas::saveLayer[Alpha] and cc::SaveLayer[Alpha]Op, - Change const PaintFlags* parameter to const PaintFlags&. Only one production callsites passed nullptr. - Add a variant without the bounds parameter, and change the existing variant to accept const SkRect& for the bounds parameter. - Change GraphicsContext::BeginLayer() to be several variants, without the bounds parameter. Previously only one caller passed the bounds parameter where the bounds didn't matter. - Remove the branch checking alpha-only flags in RecordPaintCanvas:: saveLayer() because all important callers know when to call saveLayerAlpha(). This makes the callsites clearner, and allows temporary SkRect for the bounds parameter. Change-Id: I3d8c81ef17ed26ba26c72f6cfd2a5cc9bea693a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121362 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Owners-Override: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1086856}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.