commit | 3a4e48dd183bbd969cacd017804087a305b9466d | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Wed Nov 29 10:19:36 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 29 10:19:36 2023 |
tree | 38fd0d763a3acdbad2a546a2d246084806745417 | |
parent | 961ffc058ad8fbfe44808d77f7cbdf9bf1053c69 [diff] |
[//gpu] Move SII::MapSharedImage() to ClientSharedImage::Map() All implementations are now identical and just use the GMB from ClientSI, so this method can be on ClientSI itself. This CL moves the method, updates all callers, and eliminates the no-longer-used SII interface and its implementations. Note that the ClientSI can outlive the ClientSII in the case where the ClientSII is torn down before a client has called DestroySharedImage(ClientSII). There is no particular harm from a client calling ClientSI->Map() after that point, since ClientSI->Map() accesses only the GMB. In the fullness of time, ClientSI will need to know about its creating ClientSII, including being informed of its destruction. Once we have that functionality in, we could also clear out the GMB at that point. Bug: 1500612 Change-Id: I528881d6c289d850daa1a4be5c551d1460c714b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5030455 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#1230537}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.