[go: nahoru, domu]

Reland "Set StylusHandwritingImeCallback when the web contents is updated"

StylusHandwritingImeCallback is set when web contents are updated, this allowed Direct writing service to request for edit bounds when spen hover over editable fields and blocks navigation icons (back/home/menu) to allow direct writing.

Direct writing service expects onlyRectChanged key along with bundle when only edit field bounds have changed to avoid blocking navigation icons. Issue was happening because this key was not passed with bundle.

Added onlyRectChanged key to bundle when onBoundedEditTextChanged API is called.

This is a reland of commit 2b1ed86013047fdae98768896e3954e832c19327

Original change's description:
> Set StylusHandwritingImeCallback when the web contents is updated
>
> The Stylus Handwriting Toolbar in Chromium was unresponsive when an
> input field was focused without performing any direct writing actions.
> This issue occurred due to the StylusHandwritingImeCallback being set
> only when initiating stylus writing.
>
> Set StylusHandwritingImeCallback when the web contents is updated.
> This ensures that the callback is available even when an input field
> is focused without performing direct writing action.
>
> Bug: 1455060
> Change-Id: Iba56f9d21e31372b4c378da4d2d838a0bfc231bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617691
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Commit-Queue: Mahesh Machavolu <mahesh.ma@samsung.com>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Mahesh Machavolu <mahesh.ma@samsung.com>
> Reviewed-by: Alex Mitra <alexmitra@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1162768}

Bug: 1455060
Change-Id: I18b5868326b5dd11fd6fbc5ec974e83d9cd3aeb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003916
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Mahesh Machavolu <mahesh.ma@samsung.com>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Mahesh Machavolu <mahesh.ma@samsung.com>
Reviewed-by: Alex Mitra <alexmitra@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1222764}
11 files changed
tree: 77553831bdf04f5300b25fbf9dced38a875f172d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.