commit | 470d1297e5e01a1649b4307162230679a63c428b | [log] [tgz] |
---|---|---|
author | Vinny Persky <vinnypersky@google.com> | Wed May 10 20:38:05 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 10 20:38:05 2023 |
tree | 7a2f729d2e029c068ab30ba6de5f767cfd155ebd | |
parent | 1cc6599ec908ce2af79c1bd0584fdc4be026b333 [diff] |
Mandatory re-auth integration for virtual card green path autofill This CL integrates the DeviceAuthenticator for the virtual card green path autofill flow, to require mandatory re-auth before filling the virtual card. The DeviceAuthenticator prompt freezes Chrome every time on Windows, and for the password unlock prompt on macOS. Thus, this CL ensures that we do not start the device authentication flow on these platforms until the autofill progress dialog is completely destroyed, so it does not hang in the background. method in test_autofill_client.h. It is not useful to cover this by unit tests, as this class is a test class solely created for testing components that interact with the autofill client. Bug: 1427216 Change-Id: I1048c70ac5d2e8f7580e33e48bc787a494e697ab Low-Coverage-Reason: The low coverage warning was for the new test Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4405587 Reviewed-by: Dominic Battre <battre@chromium.org> Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/main@{#1142332}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.