commit | 49ab95c1a764e10733c390dd1351ac9ff2d90c71 | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Thu Jul 06 08:17:21 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jul 06 08:17:21 2023 |
tree | cb620714d21f7885fe6996826d49f4628810c28e | |
parent | c55fcc72bfb3c3ed736af36761f3b413f0e0140e [diff] |
[@scope] Semicolons should not abort selector parsing for @scope When parsing rules under CSSNestingType::kScope, we always have some non-nullptr parent_rule_for_nesting. This would activate special error handling of semicolons (see AbortsNestedSelectorParsing) within @scope, which (at least for now) doesn't support declarations directly within its body (unless it's a nested group rule [1]): @scope (div) { z-index: 1; } For the above (invalid) case, we'd parse the body using CSSParserImpl:: ConsumeRuleList, which would try to parse 'z-index:...' as a selector via (ConsumeQualifiedRule). We would then abort at the semicolon, and then eventually return to ConsumeRuleList, which would re-enter ConsumeQualifiedRule and immediately abort at the semicolon (and so on). This CL fixes this infinite loop by adding a separate flag for the semicolon handling. This makes it possible to parse a list of rules under CSSNestingType::kScope without also getting that handling. Also added a DCHECK to make it easier to catch infinite loops in the future. Bug: 1456435 [1] https://drafts.csswg.org/css-nesting-1/#nested-group-rules Change-Id: I9660e98343bdd47522fe87296b1da7112800945a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4647597 Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1166370}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.