[go: nahoru, domu]

[@scope] Semicolons should not abort selector parsing for @scope

When parsing rules under CSSNestingType::kScope, we always have some
non-nullptr parent_rule_for_nesting. This would activate special error
handling of semicolons (see AbortsNestedSelectorParsing) within
@scope, which (at least for now) doesn't support declarations directly
within its body (unless it's a nested group rule [1]):

  @scope (div) {
    z-index: 1;
  }

For the above (invalid) case, we'd parse the body using CSSParserImpl::
ConsumeRuleList, which would try to parse 'z-index:...' as a selector
via (ConsumeQualifiedRule). We would then abort at the semicolon,
and then eventually return to ConsumeRuleList, which would re-enter
ConsumeQualifiedRule and immediately abort at the semicolon (and so on).

This CL fixes this infinite loop by adding a separate flag for the
semicolon handling. This makes it possible to parse a list of rules
under CSSNestingType::kScope without also getting that handling.

Also added a DCHECK to make it easier to catch infinite loops
in the future.

Bug: 1456435

[1] https://drafts.csswg.org/css-nesting-1/#nested-group-rules

Change-Id: I9660e98343bdd47522fe87296b1da7112800945a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4647597
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1166370}
8 files changed
tree: cb620714d21f7885fe6996826d49f4628810c28e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.