commit | 41d4d5446b9cbc10327ac200e0451d9b95823717 | [log] [tgz] |
---|---|---|
author | James Cook <jamescook@chromium.org> | Fri Dec 13 15:48:47 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 13 15:48:47 2019 |
tree | 5a7b5e72de93e28eb27a5567c88d3d160cc8e7fc | |
parent | 7997b7239d49e61e51050242f6aa573d9c3fec65 [diff] |
Move "Apps" sync toggle to OS settings on Chrome OS For SplitSettingsSync we decided that the OS sync settings "Apps" toggle should control all app types (Chrome Apps, PWAs, ARC++ apps) and the browser's "Apps" toggle should be hidden. Therefore on Chrome OS with SplitSettingsSync: * Make UserSelectableType::kApps have an empty ModelType set * Make UserSelectableOsType::kOsApps have all app types * Run ModelType syncer::APPS in sync transport-only mode, controlled by the OS sync feature pref. The browser sync settings UI automatically hides the toggle, because APPS is no longer a registered selectable (non-OS) type and the HTML/JS layer already hides non-registered types. We may later change the browser UI to have a helpful link to OS settings for apps, but this works for now. Manual test: Run chrome --enable-features=SplitSettingsSync,SyncManualStartChromeOS Add an account Enable OS sync in the first-run dialog Verify that the account's apps appear, and chrome://sync-internals shows Apps are syncing, even though browser sync is off. Also added automated tests to sync_integration_tests and components_unittests. Bug: 1031549 Change-Id: I7de7cfe09b5244053cb8ab1bd69a34c33d9e83c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964639 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#724648}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .