[go: nahoru, domu]

[//cc] Add MappableSI flow to ZeroCopyRasterBufferProvider

This CL adds a flow that uses MappableSharedImage rather than
GpuMemoryBuffer to ZeroCopyRasterBufferProvider. The new codepath is
enabled by default with a Finch killswitch. The changes for the new
flow are the following:

- Rather than creating and mapping a GMB, create and map a MappableSI
- If the MappableSI fails to map, immediately destroy it and zero out
  its mailbox.
- Where the code currently checks for failure by the GMB being null,
  check for failure via the mailbox being zero
- Dump the memory of the mapped region via ScopedMapping rather than the
  GMB

Note: As part of this change, we had to disable ZeroCopyRaster unittests
on Fuchsia due to crbug.com/1485883, a pre-existing issue that this
change tickled due to the change to the tests creating buffers via
(Mappable)SharedImage rather than TestGpuMemoryBufferManager.

Bug: 1431326, 1485883
Change-Id: I7a9875a748a42ca606c8b20d0c671f9531de8e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4881760
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1200997}
2 files changed
tree: 3672718fb3aecae79b6b9fa21cb25cf725320ad2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.