commit | 4281969a4585dbc49861e49af031e813116fb0b3 | [log] [tgz] |
---|---|---|
author | Colin Blundell <blundell@chromium.org> | Mon Sep 25 15:24:28 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 25 15:24:28 2023 |
tree | 3672718fb3aecae79b6b9fa21cb25cf725320ad2 | |
parent | e995e27590407a795c75ef9347b0b2fdbb0d4d16 [diff] |
[//cc] Add MappableSI flow to ZeroCopyRasterBufferProvider This CL adds a flow that uses MappableSharedImage rather than GpuMemoryBuffer to ZeroCopyRasterBufferProvider. The new codepath is enabled by default with a Finch killswitch. The changes for the new flow are the following: - Rather than creating and mapping a GMB, create and map a MappableSI - If the MappableSI fails to map, immediately destroy it and zero out its mailbox. - Where the code currently checks for failure by the GMB being null, check for failure via the mailbox being zero - Dump the memory of the mapped region via ScopedMapping rather than the GMB Note: As part of this change, we had to disable ZeroCopyRaster unittests on Fuchsia due to crbug.com/1485883, a pre-existing issue that this change tickled due to the change to the tests creating buffers via (Mappable)SharedImage rather than TestGpuMemoryBufferManager. Bug: 1431326, 1485883 Change-Id: I7a9875a748a42ca606c8b20d0c671f9531de8e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4881760 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1200997}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.