commit | 4b1d4eede329a753c558d715bbdb2b738f06867b | [log] [tgz] |
---|---|---|
author | Jayson Adams <shrike@chromium.org> | Mon Sep 25 21:54:09 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 25 21:54:09 2023 |
tree | 0316162506e6be15b4013c8933b3b4086daa65b6 | |
parent | 422f54d4bef7004726ac3eff33ca55a969b36162 [diff] |
[Mac Sonoma Tests] Fix flaky EditableComboboxTest.RefocusingReopensMenuBasedOnLatestContent ~ScopedFakeNSWindowFocus calls ClearFocus(), which spawns NSWindowDidResign* notifications. Observers like NSRemoteView can throw an exception if the window in the notification is nil. This cl avoids posting NSWindowDidResign* notifications if there is no resigning window. Test: out/Debug/views_unittests \ --gtest_filter="EditableComboboxTest.RefocusingReopensMenuBasedOnLatestContent" Bug: 1486600 Change-Id: I6262fe77ca7bc5aa8af995f50da93ba4b59ca25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4892448 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/main@{#1201168}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.